Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8.0 Deployment #553

Merged
merged 4 commits into from
Dec 19, 2024
Merged

8.0 Deployment #553

merged 4 commits into from
Dec 19, 2024

Conversation

BHoMBot
Copy link
Member

@BHoMBot BHoMBot commented Dec 9, 2024

Robot_Toolkit

Compliance

@Chrisshort92 Chrisshort92 self-assigned this Dec 9, 2024
@Chrisshort92 Chrisshort92 self-requested a review December 9, 2024 17:39
@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Dec 10, 2024

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on BHoM

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Dec 10, 2024

@BHoMBot just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on BHoM

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Dec 10, 2024

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on SQL_Toolkit

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Dec 11, 2024

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on BHoM

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Dec 11, 2024

@BHoMBot just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on BHoM

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Dec 11, 2024

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on SQL_Toolkit

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Dec 12, 2024

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on BHoM

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Dec 12, 2024

@BHoMBot just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on BHoM

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Dec 12, 2024

@IsakNaslundBh I am now running force checks on the checks requested. These will be queued and actioned ASAP.

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Dec 12, 2024

@IsakNaslundBh I have provided force checks to the checks requested.

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Dec 13, 2024

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on BHoM_Engine

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Dec 13, 2024

@BHoMBot just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on BHoM_Engine

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Dec 13, 2024

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on BHoMAnalytics_Toolkit

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Dec 16, 2024

@BHoMBot just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on Revit_UI

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Dec 16, 2024

@BHoMBot just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on Revit_Schematic_Tool

@bhombot-ci bhombot-ci bot added the type:feature New capability or enhancement label Dec 16, 2024
@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Dec 17, 2024

@BHoMBot just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on Revit_Tagging_Tool

Chrisshort92
Chrisshort92 approved these changes Dec 18, 2024
View reviewed changes
Copy link

@Chrisshort92 Chrisshort92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested by @HugoVanLooveren and @Chrisshort92 .

Hugo - "Dynamics checks to be included
Checked chapter 1 & 2 from the tetsting procedure, all worked fine.(13/12)
Also checked 3 & 4, both fine.
Number 5 I got red errors when pulling results, but do not understand the case filters and selection of the script. - no time left to further check (18/12)"

Chris - "Test with BuroHappold_BHoM_8.0.241217.beta.0.

Results file worked as expected. Test script had a bug with filtering the cases. All functions worked as expected in this file."

Passed for Approval.

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Dec 19, 2024

@BHoMBot just to let you know, I have provided a check-ready-to-merge result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM

@IsakNaslundBh IsakNaslundBh merged commit aecee7e into main Dec 19, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chrisshort92 Chrisshort92 Chrisshort92 approved these changes

Assignees

@Chrisshort92 Chrisshort92

Labels
type:feature New capability or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BHoMBot @Chrisshort92 @IsakNaslundBh @adecler